tests/record: Compare request body in plain text if content-type: text/plain is used
#6326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
…xt/plain` is used
Turbo87
force-pushed
the
plaintext-recorder
branch
from
3d93a8a to
9ed64af
Compare
LawnGnome
added a commit
to LawnGnome/crates.io
that referenced
this pull request
Jun 13, 2023
In rust-lang#6326, `text/plain` request payloads were decoded into... well, plain text, and `record::replay_http` was updated to handle them accordingly. The code that records those request payloads was not updated, however, so any updated test payload will now result in failures, since a base64 encoded string will be compared against a plain text string. This adds the same logic to `record::record_http` to ensure newly recorded cassettes match.
Turbo87
pushed a commit
that referenced
this pull request
Jun 13, 2023
…#6603) In #6326, `text/plain` request payloads were decoded into... well, plain text, and `record::replay_http` was updated to handle them accordingly. The code that records those request payloads was not updated, however, so any updated test payload will now result in failures, since a base64 encoded string will be compared against a plain text string. This adds the same logic to `record::record_http` to ensure newly recorded cassettes match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #6318 and makes it easier to work with HTTP request recordings that are using a
text/plaincontent type header. In this case we will assume the content is utf8-encoded and compare the strings directly, instead of using base64 encoding.